-
Notifications
You must be signed in to change notification settings - Fork 8.1k
stm32: samples: drivers: i2s: output: board: update nucleo_u385rg_q sa1 pins node #94082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
33a64aa
to
b31f213
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
required: zephyrproject-rtos/hal_stm32#301
Please update west.yaml if actually needed
b31f213
to
78153ce
Compare
Done |
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
78153ce
to
528eddb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but prefer with indentation issue fixed.
pinctrl-0 = <&sai1_mclk_a_pb8 &sai1_sd_a_pc1 | ||
&sai1_fs_a_pa9 &sai1_sck_a_pb10>; | ||
pinctrl-0 = <&sai1_mclk_a_pb8 &sai1_sd_a_pc3 | ||
&sai1_fs_a_pb9 &sai1_sck_a_pb10>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indenation
pinctrl-0 = <&sai1_mclk_a_pb8 &sai1_sd_a_pc3
&sai1_fs_a_pb9 &sai1_sck_a_pb10>;
or even:
pinctrl-0 = <&sai1_mclk_a_pb8 &sai1_sd_a_pc3 &sai1_fs_a_pb9 &sai1_sck_a_pb10>;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Choose another sai1_fs_a pin available to avoid the need to disable the Zephyr-chosen console and i2c3 node. Signed-off-by: Fabrice DJIATSA <[email protected]>
528eddb
to
bada408
Compare
|
This PR adds changes related to an issue observed in the I2S output test on the NUCLEO_U385RG_Q.
See here for more details : #92575 (comment)
required: zephyrproject-rtos/hal_stm32#301